[Logging] Add fuzz-related logs context to corpus pruning task #4774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if self == LogContextType.FUZZ: | ||
| try: | ||
| return FuzzLogStruct( | ||
| fuzzer=log_contexts.meta.get('fuzzer_name', 'null'), |
There was a problem hiding this comment.
WHy not return None instead of "null"?
There was a problem hiding this comment.
I'm not entirely sure how the gcp logging treats fields that are set to None, my guess is that it omits that field. IMO it's better to have this default value meaning that the information is missing/not applicable than omitting it, which could mean that something went wrong during logging.
( I also used this piece of code as reference: https://github.com/google/clusterfuzz/blob/master/src/clusterfuzz/_internal/metrics/logs.py#L420 )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differently from the tasks instrumented with logs context so far, corpus pruning (and fuzz task) is not based on a testcase. These two in particular operate on top of fuzzers, jobs and fuzz targets. This PR: