Skip to content

[Logging] Add testcase-based log context to analyze, blame and impact tasks #4771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 28, 2025

Conversation

ViniciustCosta
Copy link
Collaborator

@ViniciustCosta ViniciustCosta commented Apr 23, 2025

  • Added the testcase-based structured logs to the analyze, blame and impact tasks.
  • Added the task logs context decorator to a missing entry point for trusted tasks.
  • Reverted some changes in symbolize task where the private methods I had created (e.g. _utask_postprocess) were receiving the testcase as argument (because it was already retrieved for the logs context). However, this could create an issue if, in the original method, the testcase was updated before the get_testcase.

@ViniciustCosta ViniciustCosta marked this pull request as ready for review April 23, 2025 18:25
Copy link
Collaborator

@vitorguidi vitorguidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@javanlacerda javanlacerda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any tests we can add for it?

@ViniciustCosta
Copy link
Collaborator Author

Is there any tests we can add for it?

This didn't change anything in the logs, just instrumented the remaining tasks, so I don't think we can add tests for this (at least considering the as is of the tests).

@javanlacerda
Copy link
Contributor

Is there any tests we can add for it?

This didn't change anything in the logs, just instrumented the remaining tasks, so I don't think we can add tests for this (at least considering the as is of the tests).

That's fair!

@ViniciustCosta ViniciustCosta merged commit d8801c5 into master Apr 28, 2025
7 checks passed
@ViniciustCosta ViniciustCosta deleted the feat/add_testcase_logs_to_tasks branch April 28, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants