-
Notifications
You must be signed in to change notification settings - Fork 573
[Logging] Add testcase-based log context to analyze, blame and impact tasks #4771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any tests we can add for it?
This didn't change anything in the logs, just instrumented the remaining tasks, so I don't think we can add tests for this (at least considering the as is of the tests). |
That's fair! |
_utask_postprocess
) were receiving the testcase as argument (because it was already retrieved for the logs context). However, this could create an issue if, in the original method, the testcase was updated before theget_testcase
.