-
Notifications
You must be signed in to change notification settings - Fork 573
Update appengine imports for external_testcase_reader. #4708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
aed7b9e
to
748cd47
Compare
(context failure logs: http://shortn/_BBefaIUwXU) |
748cd47
to
721c92b
Compare
updated! i do not actually know if the problem of the imports is to be fixed by adding that to the path - but does that seem like a sensible solution to you?? |
So the issue is coming from these two imports:
Looking at the other cron jobs in the same directory, I noticed non of them use appengine imports. Also, I noticed that for cron jobs like cleanup (
Same pattern exists for predator_pull and triage in https://github.com/google/clusterfuzz/tree/8e43b8b4bc7b984defe62654a2ec05365a7fdb7f/src/appengine/handlers/cron.
The right approach might be similar to what was done for these three cron jobs. Adding @jonathanmetzman as the code owner. |
72d5d6f
to
7eba2c8
Compare
7eba2c8
to
c7f4fb9
Compare
(drive by add additional component filter in query for extra safety)