Skip to content

Update appengine imports for external_testcase_reader. #4708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pgrace-google
Copy link
Collaborator

(drive by add additional component filter in query for extra safety)

@pgrace-google
Copy link
Collaborator Author

(context failure logs: http://shortn/_BBefaIUwXU)

@pgrace-google
Copy link
Collaborator Author

updated!

i do not actually know if the problem of the imports is to be fixed by adding that to the path - but does that seem like a sensible solution to you??

@alhijazi
Copy link
Collaborator

alhijazi commented Mar 3, 2025

updated!

i do not actually know if the problem of the imports is to be fixed by adding that to the path - but does that seem like a sensible solution to you??

So the issue is coming from these two imports:

from appengine.libs import form
from appengine.libs import gcs

Looking at the other cron jobs in the same directory, I noticed non of them use appengine imports.

Also, I noticed that for cron jobs like cleanup (

# you may not use this file except in compliance with the License.
), there's an appengine cron handler called cleanup located here:
# you may not use this file except in compliance with the License.

Same pattern exists for predator_pull and triage in https://github.com/google/clusterfuzz/tree/8e43b8b4bc7b984defe62654a2ec05365a7fdb7f/src/appengine/handlers/cron.

The right approach might be similar to what was done for these three cron jobs.

Adding @jonathanmetzman as the code owner.

@pgrace-google pgrace-google force-pushed the fix-appengine branch 2 times, most recently from 72d5d6f to 7eba2c8 Compare April 13, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants