-
Notifications
You must be signed in to change notification settings - Fork 435
Add “Save to Local” buttons and chat/voice interaction to Maps, Annotation, and Video modules #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @morningstarxcdcode, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly enhances user interaction and data management capabilities across the Maps, Annotation, and Video modules. It introduces direct local data export, integrates conversational AI into the Maps experience, and includes important security and UI refinements to improve the overall application usability and safety.
Highlights
- Data Export Functionality: Introduced 'Save to Local' buttons across the Maps, Annotation (Spatial), and Video modules. This allows users to download relevant module data, such as map location and caption, spatial annotations (bounding boxes, points, lines), and the current video module state, as local files.
- Maps AI Integration: Added Gemini AI chat and voice interaction capabilities to the Maps module. Users can now type or speak queries to the AI, and the AI's responses are displayed in a chat interface and also spoken aloud via text-to-speech.
- Enhanced Embed Security: Improved the security of embedded Google Maps iframes by adding a
sandbox
attribute, restricting potential malicious content and enhancing user safety. - UI/UX and Backend Refinements: Updated color styling in the Spatial module for better text readability on captions and modified the video player to display timecodes with millisecond precision. Additionally, the video server's temporary file handling was made more robust by using
os.tmpdir()
.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces several new features, including "Save to Local" buttons, chat and voice interaction in the Maps, Annotation, and Video modules. The changes look good overall, but there are some security and maintainability concerns that need to be addressed. The most important issue is the insecure sandbox configuration in maps/function-declarations.js
, which could lead to serious security vulnerabilities. Additionally, the XSS vulnerability in maps/script.js
needs to be fixed to prevent malicious users from injecting arbitrary code into the application. Finally, the duplicated file download logic in spatial/src/hooks.tsx
should be refactored into a reusable utility function to improve code maintainability.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Hey guys! I added “Save to Local” buttons in maps, annotations, and videos so you can download your data super easily. Also, the Maps now let you chat or talk with Gemini AI, and it talks back too! Plus, I fixed some colors so text looks cleaner and made embeds safer. Hope this makes using the app way more fun and safe. Let me know what you think or wanna add!
Feel free to tweak based on your style! The key is to be honest, clear, polite, and highlight the user benefits. 😊