Fix for Google Maps links being blocked in Place Explorer map

[morningstarxcdcode]

Hey! I noticed that when you try to click on the "View on Google Maps" link inside the Place Explorer map, it wasn’t working because the browser was blocking it. So, I made a quick fix!

Basically, I added a sandbox attribute to the iframe that shows the map in the maps/function-declarations.js file. This lets the iframe open the links in a new window without the browser blocking it due to security restrictions. Now, those links should open smoothly in a fresh tab or window without any annoying errors.

Let me know if you want me to change or improve anything. Thanks a lot! 😊

the pull request is for this issue:

#23

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Summary of Changes

Hello @morningstarxcdcode, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've addressed an issue where "View on Google Maps" links within the Place Explorer map were being blocked by the browser. This fix involves adjusting the iframe's sandbox attributes to allow these links to open correctly. Additionally, I've implemented a "Save to Local" feature across the Maps, Spatial, and Video modules, enabling users to download relevant application state data for offline use or further analysis.

Highlights

• Google Maps Link Fix: I've updated maps/function-declarations.js to include a sandbox attribute with allow-scripts allow-popups allow-forms allow-same-origin allow-popups-to-escape-sandbox values on the Google Maps iframe. This resolves the browser blocking "View on Google Maps" links, allowing them to open in a new window.
• "Save to Local" Feature for Maps: I've added a "Save to Local" button to maps/index.html and implemented its functionality in maps/script.js. Clicking this button now allows users to download a text file containing the current map location and caption.
• "Save to Local" Feature for Spatial Module: I've introduced a useSaveState hook in spatial/src/hooks.tsx and integrated a "Save to Local" button into spatial/src/TopBar.tsx. This enables users to download the current spatial state (image source, bounding boxes, points, lines, and detection type) as a JSON file.
• "Save to Local" Feature for Video Module: I've added a saveState function and a corresponding "Save to Local" button in video/src/App.jsx. This allows users to download the current video module's state (video URL, timecode list, selected modes, prompts, and chart labels) as a JSON file.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.