-
Notifications
You must be signed in to change notification settings - Fork 8.9k
Remove separate --path argument for extensions install command #10628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @chrstnb, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with π and π on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Size Change: -162 B (0%) Total Size: 17.6 MB βΉοΈ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the extensions install command to use a single positional argument for both git URLs and local paths. The changes are mostly good, but I've found a few areas for improvement related to error handling and argument validation that I've marked as high severity. Specifically, the error handling for local paths can be improved to provide more accurate error messages, the argument validation can be centralized within the yargs command builder, and a test mock should be improved to better simulate real-world errors. Please see my detailed comments.
Co-authored-by: Jacob MacDonald <[email protected]> Co-authored-by: Adam Weidman <[email protected]>
β¦s install command (google-gemini#10628)
Gemini CLI 8.0 release introduced [PR#10628](google-gemini/gemini-cli#10628) which removes the need for a path/source argument when installing extensions and breaks run-gemini-cli's extension installation. Removing `--source` and relying on positional arguments patches `run-gemini-cli` for Gemini CLI 8.0+ I've tested this locally as well in CallumHYoung/testrepo#3 which relies on https://github.com/CallumHYoung/run-gemini-cli
TLDR
Use the positional argument instead
Dive Deeper
Reviewer Test Plan
Testing Matrix
Linked issues / bugs