Skip to content

Conversation

@chrstnb
Copy link
Collaborator

@chrstnb chrstnb commented Oct 7, 2025

TLDR

Use the positional argument instead

Dive Deeper

Reviewer Test Plan

Testing Matrix

🍏 πŸͺŸ 🐧
npm run ❓ ❓ ❓
npx ❓ ❓ ❓
Docker ❓ ❓ ❓
Podman ❓ - -
Seatbelt ❓ - -

Linked issues / bugs

@chrstnb chrstnb requested a review from a team as a code owner October 7, 2025 01:47
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @chrstnb, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the gemini extensions install command by eliminating the need for a separate --path argument. Users can now provide either a Git repository URL or a local directory path directly as the source argument, simplifying the command-line interface. The underlying logic has been enhanced to automatically detect the type of source and apply appropriate validation, ensuring a more intuitive and robust user experience for installing extensions.

Highlights

  • Unified install command argument: The --path argument for gemini extensions install has been removed. Local paths are now passed directly as the source positional argument, unifying the command's interface.
  • Automatic source type detection: The install command now intelligently determines if the provided source is a Git URL or a local file path by attempting to stat the path if it doesn't match a known URL pattern.
  • Improved argument validation: The command now prevents the use of Git-specific options (--ref, --auto-update) when installing a local extension, providing clearer error messages.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with πŸ‘ and πŸ‘Ž on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@github-actions
Copy link

github-actions bot commented Oct 7, 2025

Size Change: -162 B (0%)

Total Size: 17.6 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 17.6 MB -162 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 830 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the extensions install command to use a single positional argument for both git URLs and local paths. The changes are mostly good, but I've found a few areas for improvement related to error handling and argument validation that I've marked as high severity. Specifically, the error handling for local paths can be improved to provide more accurate error messages, the argument validation can be centralized within the yargs command builder, and a test mock should be improved to better simulate real-world errors. Please see my detailed comments.

@chrstnb chrstnb added this pull request to the merge queue Oct 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 7, 2025
@chrstnb chrstnb added this pull request to the merge queue Oct 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 7, 2025
@chrstnb chrstnb added this pull request to the merge queue Oct 7, 2025
Merged via the queue into main with commit d93e987 Oct 7, 2025
20 checks passed
@chrstnb chrstnb deleted the cb/path2 branch October 7, 2025 16:10
chrstnb added a commit that referenced this pull request Oct 7, 2025
Co-authored-by: Jacob MacDonald <[email protected]>
Co-authored-by: Adam Weidman <[email protected]>
thacio added a commit to thacio/auditaria that referenced this pull request Oct 7, 2025
jerop pushed a commit to google-github-actions/run-gemini-cli that referenced this pull request Oct 8, 2025
Gemini CLI 8.0 release introduced
[PR#10628](google-gemini/gemini-cli#10628) which
removes the need for a path/source argument when installing extensions
and breaks run-gemini-cli's extension installation.

Removing `--source` and relying on positional arguments patches
`run-gemini-cli` for Gemini CLI 8.0+

I've tested this locally as well in
CallumHYoung/testrepo#3 which relies on
https://github.com/CallumHYoung/run-gemini-cli
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants