-
Notifications
You must be signed in to change notification settings - Fork 8.7k
chore: add a2a server bin #10592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add a2a server bin #10592
Conversation
Summary of ChangesHello @adamfweidman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request transforms the @google/gemini-cli-a2a-server package into a standalone executable, making it publishable and directly usable as a command-line tool. This is achieved by configuring the package.json to expose a binary entry point and adding a shebang to the server's main script, while maintaining its existing module import functionality. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully makes the @google/gemini-cli-a2a-server
package executable by adding a bin
entry to package.json
and a shebang to the server entrypoint. While the changes are generally correct, I've identified a potential high-severity issue where a process-wide exception handler is registered unconditionally. This could lead to unintended side effects if the server module is imported by other applications. My review comment details this issue and suggests a fix to improve the package's robustness.
Size Change: -2 B (0%) Total Size: 17.8 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TLDR
expose @google/gemini-cli-a2a-server as an executable npm package by wiring its bin entry to the compiled server entrypoint
Dive Deeper
I confirmed this worked with GCA in cl/815948932. Reproduce by:
a2a-server/package.json
change core package to "@google/gemini-cli-core": "0.9.0-nightly.20251002.0f465e88".npm pack --workspace=@google/gemini-cli-a2a-server
yarn install
Reviewer Test Plan
Testing Matrix
This PR makes progress on #9207