Skip to content

Conversation

hritan
Copy link
Collaborator

@hritan hritan commented Oct 6, 2025

TLDR

Dive Deeper

Reviewer Test Plan

Testing Matrix

🍏 πŸͺŸ 🐧
npm run ❓ ❓ ❓
npx ❓ ❓ ❓
Docker ❓ ❓ ❓
Podman ❓ - -
Seatbelt ❓ - -

Linked issues / bugs

Copy link

github-actions bot commented Oct 6, 2025

Size Change: -2 B (0%)

Total Size: 17.7 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 17.7 MB -2 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 830 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

@hritan hritan marked this pull request as ready for review October 7, 2025 14:41
@hritan hritan requested a review from a team as a code owner October 7, 2025 14:41
@hritan hritan requested a review from jacob314 October 7, 2025 14:42
Copy link
Collaborator

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved after the comment is addressed assuming running the test 20 times on windows shows it is actually flake free and we didn't just get lucky on a couple of runs.

true,
);

await type(ptyProcess, '/co');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a comment on why this required along with a link to the bug tracking the underlying issue that calling tools right after startup appears to sometimes fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants