-
Notifications
You must be signed in to change notification settings - Fork 8.5k
test: enable interactive integration tests for windows #10586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Size Change: -2 B (0%) Total Size: 17.7 MB βΉοΈ View Unchanged
|
β¦o hriday/enable_win_int_tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved after the comment is addressed assuming running the test 20 times on windows shows it is actually flake free and we didn't just get lucky on a couple of runs.
true, | ||
); | ||
|
||
await type(ptyProcess, '/co'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a comment on why this required along with a link to the bug tracking the underlying issue that calling tools right after startup appears to sometimes fail.
TLDR
Dive Deeper
Reviewer Test Plan
Testing Matrix
Linked issues / bugs