-
Notifications
You must be signed in to change notification settings - Fork 8.7k
chore: Extract '.gemini' to GEMINI_DIR constant #10540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Extract '.gemini' to GEMINI_DIR constant #10540
Conversation
Summary of ChangesHello @terrydkim, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is a significant refactoring effort aimed at enhancing the maintainability and consistency of the codebase. It centralizes the definition of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively consolidates all definitions of the '.gemini'
directory into a single GEMINI_DIR
constant, sourced from packages/core/src/utils/paths.ts
. The refactoring is thorough, touching application logic, test files, and utility scripts, which successfully eliminates duplicate definitions and hardcoded strings. This is a valuable improvement for code maintainability. After a detailed review of all changes, I found them to be correct and consistent with the stated goal. There are no high or critical issues to report.
6735a88
to
794b17c
Compare
…tant # Conflicts: # packages/a2a-server/src/config/extension.ts # packages/cli/src/config/extensions/extensionEnablement.test.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Terry! Appreciate your assistance in our quest to pay down some technical debt :). This is really appreciated.
Co-authored-by: Richie Foreman <[email protected]>
Co-authored-by: Richie Foreman <[email protected]>
Fixes #7414
TLDR
Eliminates all duplicate
.gemini
directory definitions across the codebase by consolidating to a single source:GEMINI_DIR
frompackages/core/src/utils/paths.ts
.What changed:
SETTINGS_DIRECTORY_NAME
,GEMINI_CONFIG_DIR
'.gemini'
strings withGEMINI_DIR
importDive Deeper
Urgency: Without this consolidation, new code will continue introducing hardcoded
.gemini
strings and creating new aliases, making the technical debt worse. This PR establishes the pattern going forward.Files affected:
Zero functional changes - pure refactoring for maintainability.
Reviewer Test Plan
Run full test suite:
npm test
— all green on macOSTesting Matrix
(Tested on macOS with
npm run
- all tests pass)Linked issues / bugs
Fixes #7414