-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Document plural forms and translation context in Localization using spreadsheets #11421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document plural forms and translation context in Localization using spreadsheets #11421
Conversation
0fe0e95 to
4572c4b
Compare
|
@Calinou This needs a rebase now after the CI was fixed |
4572c4b to
e29e21e
Compare
|
cc @timothyqiu @bruvzg Would be great if we could get either of you to give this a brief glance :) (Also see the questions in the PR description) |
I can't reproduce the problem. Try the test project here: godotengine/godot#112073 (comment)
It already works. Generally speaking, IDs shouldn't be ambiguous, right? # This already works.
tr("SOME_ID", "Context A")
tr("SOME_ID", "Context B")
# But this is more ideal, and can use auto-translation.
tr("CONTEXT_A_SOME_ID")
tr("CONTEXT_B_SOME_ID")For plurals, I'd say It's a plural message as long as # This already works.
tr_n("SOME_ID", "Plural", n)
tr_n("ANOTHER_ID", "Plural", n)
In the class reference of Since both context and plural functionality require the use of |
…preadsheets - Wrap localization pages to around 80 characters.
e29e21e to
e64fed5
Compare
|
Thank you, and thanks to the reviewers! Merged. |
Note that I can't get this to work locally, see godotengine/godot#112073 (comment). I'm running into the same issue with plurals according to the example CSV given.
Also, is it possible to make either of these features work when using IDs for translation keys instead of plain English strings? We still recommend using IDs for CSV translation in general, so it's strange to see the documentation suddenly shift to English IDs with no explanation.