[WIP] Add CODEOWNERS #11401
[WIP] Add CODEOWNERS #11401
Conversation
|
Is it necessary to specify Edit: I see you've done right just this at the end of the file, so why doing it for every other line? |
|
It cannot be done once only, unfortunately, it would be great if it worked that way but it doesn't |
.github/CODEOWNERS
Outdated
| /tutorials/export/*ios* @godotengine/ios @godotengine/documentation | ||
| /tutorials/export/*linux* @godotengine/linux-bsd @godotengine/documentation | ||
| /tutorials/export/*macos* @godotengine/macos @godotengine/documentation | ||
| /tutorials/export/*visionos* @godotengine/ios @godotengine/documentation |
There was a problem hiding this comment.
There isn't a specific team for this, so unsure what to add here, ownership is also missing from the main repo for this platform
.github/CODEOWNERS
Outdated
|
|
||
| /*.* @godotengine/documentation | ||
|
|
||
| # TODO: Should the build related files, like `.py` be owned by the doc team or buildsystem? |
There was a problem hiding this comment.
I would make them owned by the buildsystem team.
There was a problem hiding this comment.
Then I'll add them and see what cases are relevant, might make the root folder buildsystem and filter more finely for the global assignment for documentation
AThousandShips
force-pushed
the
doc_ownership
branch
from
d38cde6 to
284848a
Compare
|
There cleaned up the formatting and added some new entries, will continue next week! |
AThousandShips
force-pushed
the
doc_ownership
branch
from
284848a to
29a9784
Compare
|
|
||
| ## --------------- Plugins ------------------------- | ||
|
|
||
| # TODO: Who should control this beyond documentation? |
There was a problem hiding this comment.
We don't have an 'editor' team right now (we should!); currently i'd say "Docks" is the closest match?
|
|
||
| ## --------------- Scripting ----------------------- | ||
|
|
||
| # TODO: Who should control this in general beyond documentation? |
There was a problem hiding this comment.
Scripting is technically owned by Core, but the gdscript and dotnet teams should be better familiar with the APIs. The information in here seems to be a mix of all, maybe we need to do it on a case by case basis.
| ## --------------- XR ------------------------------ | ||
|
|
||
| /tutorials/xr/ @godotengine/documentation @godotengine/xr | ||
|
|
||
| # TODO: Should any of these also have rendering ownership when rendering related? |
There was a problem hiding this comment.
Forwarding this question to @godotengine/xr
|
|
||
| ## --------------- i18n ---------------------------- | ||
|
|
||
| # TODO: Who should control this beyond documentation? |
There was a problem hiding this comment.
I don't think translations has a dedicated team. Historically I think some maintainers have been contributing to this area more than others though, so there is certainly some 'inofficial ownership' here too.
In the main repo, PRs for translations end up in core, though I'm not sure it's a great fit. Perhaps this also needs a dedicated team?
There was a problem hiding this comment.
We genuinely need to discuss more team subdivisions. See how some topics aren't a perfect match and some are missing, and you can understand why I have a personal tendency to bring this topic up where it doesn't fit.
When this specific section shows up, it's usually argued it belongs in usability.
| /tutorials/editor/ @godotengine/documentation @godotengine/docks | ||
| /tutorials/editor/*script* @godotengine/documentation @godotengine/script-editor | ||
|
|
||
| # TODO: Who should control this beyond docs? |
There was a problem hiding this comment.
I'd attribute it to docks, since that's the closest we have to an editor team.
But I'd also argue we should establish an editor team 😅
|
|
||
| ## --------------- Best Practices ------------------ | ||
|
|
||
| # TODO: Who should control this beyond documentation? |
There was a problem hiding this comment.
We probably need to do this either on a file-by-file basis, or case-by-case basis.
|
|
||
| # ---------------- Community ----------------------- | ||
|
|
||
| # TODO: Who should control this beyond documentation? |
There was a problem hiding this comment.
Probably the @godotengine/communication team?
|
Thank you for your suggestions! Will go over this again some time this week |
AThousandShips
force-pushed
the
doc_ownership
branch
from
29a9784 to
613a360
Compare
|
Applied a few of the suggestions and will see about additional cases next week |
4 participants
Several areas missing but as a starting point to figure out the specifics