fixed fixCharset ignore not enough bug #755
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WGH-
requested changes
Apr 10, 2023
| strings.Contains(contentType, "font/") { | ||
| // These MIME types should not have textual data. | ||
|
|
||
| if !strings.Contains(contentType, "text/") { |
There was a problem hiding this comment.
I agree that the original check is too simplistic, but they're a lot of textual MIME types without text/ that might have encoding problems as well. There are application/xhtml+xml, application/xml, application/atom+xml, to name a few.
Comment on lines
+467
to
+472
| func FixCharset(f bool) CollectorOption { | ||
| return func(c *Collector) { | ||
| c.fixCharset = f | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
How is this different from DetectCharset option?
There was a problem hiding this comment.
if fixCharset set false, user can fix charset onResponse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixCharset ignore all non text content type