Skip to content

Conversation

@enzo-bitfly
Copy link
Contributor

See: BEDS-106

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 7, 2025

Deploying beaconchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3b2e710
Status: ✅  Deploy successful!
Preview URL: https://d05460dd.beaconchain.pages.dev
Branch Preview URL: https://fe-106-api-enterprise-plan-s.beaconchain.pages.dev

View logs

@enzo-bitfly enzo-bitfly force-pushed the FE-106-api-enterprise-plan-section branch from 7cd5606 to 975abb2 Compare October 7, 2025 08:47
@enzo-bitfly enzo-bitfly changed the title feat: add api enterprise plan section to api pricing page feat: add enterprise plan section to api pricing page Oct 7, 2025
@enzo-bitfly enzo-bitfly force-pushed the FE-106-api-enterprise-plan-section branch from 975abb2 to 00893c1 Compare October 7, 2025 09:42
@marcel-bitfly marcel-bitfly force-pushed the FE-106-api-enterprise-plan-section branch from 00893c1 to 3b2e710 Compare October 8, 2025 07:31
Comment on lines +13 to +15
borderRadius?: '4xl' | 'xl',
elevation?: '1' | '2',
gap?: '5xl' | 'xl',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: these are too many moving pieces

we should either speak with the design team, if there could be fewer options or we should assume that only the elevation level change this is provided as prop then.
Otherwise having styling options as props on a BaseCard is kinda pointless and we rather slap on classes.

In the end for example we want to have 2 or 3 different versions of a BaseCard.

<BaseCard
  elevation="1 | 2 | 3"
...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. The thing is, higher elevation also means a card is contained by another card of lower elevation, so it is of a smaller grouping scale and its spacing will likely be smaller too.
We can either only use elevation as a prop like you said, and set gaps with fall-through classes, or let elevation affect both bg color and gap - but I'm not sure that will work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants