(BEDS-1540) omitting missing efficiencies #1620
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remoterami
force-pushed
the
BEDS-1540/api-omit-efficiencies
branch
from
0d68f6a to
5a8c322
Compare
Deploying beaconchain with
|
| Latest commit: |
c7e2bd7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://99a96300.beaconchain.pages.dev |
| Branch Preview URL: | https://beds-1540-api-omit-efficienc.beaconchain.pages.dev |
LuccaBitfly
requested changes
Jun 4, 2025
| }) | ||
|
|
||
| retrieveApr := func(timeFrame enums.TimePeriod, apr *float64) { | ||
| retrieveApr := func(timeFrame enums.TimePeriod, apr **float64) { |
There was a problem hiding this comment.
issue: Why do we pass double pointers here? Why not leave these funcs as they are, and rather call retrieveApr(enums.Last30d, data.Last30dApr)? Goes for all other double pointers in this PR
There was a problem hiding this comment.
Because we want to modify the original underlying value of the response struct, just like before. Essentially the first pointer is a reference if you're familiar with that concept from C, and we're just updating the data type from float64 to *float64 in order to allow returning undefined values
remoterami
force-pushed
the
BEDS-1540/api-omit-efficiencies
branch
2 times, most recently
from
248c1fa to
3a11291
Compare
remoterami
force-pushed
the
BEDS-1540/api-omit-efficiencies
branch
from
3a11291 to
c7e2bd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.