Skip to content

[Proposal] Add new RolloutBucketID field #1590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Proposal] Add new RolloutBucketID field #1590

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions src/XIVLauncher.Common/Dalamud/DalamudUpdater.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,14 @@ public FileInfo Runner

public string? RolloutBucket { get; }

/// <summary>
/// A bucket ID for canary releases. Currently calculated based on the creation time of the install folder.
/// It is not within our interests to allow users to opt in (or out) of canary, so this is a calculated value.
///
/// Current precision: 1,000 buckets (min rollout 0.1% of users)
/// </summary>
public uint RolloutBucketId { get; private set; }

public enum DownloadState
{
Unknown,
Expand All @@ -73,13 +81,8 @@ public DalamudUpdater(DirectoryInfo addonDirectory, DirectoryInfo runtimeDirecto
this.configDirectory = configDirectory;
this.cache = cache;

this.RolloutBucket = dalamudRolloutBucket;

if (this.RolloutBucket == null)
{
var rng = new Random();
this.RolloutBucket = rng.Next(0, 9) >= 7 ? "Canary" : "Control";
}
this.RolloutBucketId = (uint)this.addonDirectory.CreationTimeUtc.Ticks % 1_000;
this.RolloutBucket = dalamudRolloutBucket ?? (this.RolloutBucketId % 10 >= 7 ? "Canary" : "Control");
}

public void SetOverlayProgress(IDalamudLoadingOverlay.DalamudUpdateStep progress)
Expand Down Expand Up @@ -150,7 +153,8 @@ private static string GetBetaTrackName(DalamudSettings settings) =>
NoCache = true,
};

var versionInfoJsonRelease = await client.GetStringAsync(DalamudLauncher.REMOTE_BASE + $"release&bucket={this.RolloutBucket}").ConfigureAwait(false);
var versionPath = DalamudLauncher.REMOTE_BASE + $"release&bucket={this.RolloutBucket}&bucketId={this.RolloutBucketId}";
var versionInfoJsonRelease = await client.GetStringAsync(versionPath).ConfigureAwait(false);

DalamudVersionInfo versionInfoRelease = JsonConvert.DeserializeObject<DalamudVersionInfo>(versionInfoJsonRelease);

Expand Down