Skip to content

Conversation

@ecrupper
Copy link
Contributor

@ecrupper ecrupper commented Aug 26, 2025

ref: go-vela/community#1061

Breaking Changes

  • New database field for repos merge_queue_events, which will be a list of events that the merge_group event build will report to. This is necessary to preserve normal required status checks while also allowing for a merge queue. Vela is event-based in its status checks, not job-name-based. So required checks from a pull_request build will need to be targeted for merge_group events.

Opt In

Ultimately, this is opt-in functionality. If users do not supply any override events, then Vela will behave the exact same.

Pipeline Changes

steps:
  - name: tests
     image: golang:latest
     ruleset:
        event: [ pull_request, merge_group ] 
     commands:
       - go test ./...

Auto Cancel

Determining stale builds for a merge group is different than normal builds. Stale builds are defined as builds that are pending or running that are part of the merge group and also include a build that failed. There's a more detailed description of this in the reference link.

@ecrupper ecrupper requested a review from a team as a code owner August 26, 2025 16:57
@codecov
Copy link

codecov bot commented Aug 26, 2025

Codecov Report

❌ Patch coverage is 20.94763% with 317 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.80%. Comparing base (6375b9f) to head (592c07f).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
api/build/cancel.go 0.00% 115 Missing ⚠️
api/webhook/post.go 0.00% 77 Missing ⚠️
scm/github/webhook.go 0.00% 58 Missing and 1 partial ⚠️
database/testutils/api_resources.go 0.00% 25 Missing ⚠️
api/repo/update.go 0.00% 11 Missing ⚠️
api/repo/create.go 0.00% 10 Missing ⚠️
api/build/restart.go 0.00% 7 Missing ⚠️
scm/github/repo.go 87.50% 4 Missing and 2 partials ⚠️
api/build/update.go 0.00% 4 Missing ⚠️
api/build/auto_cancel.go 0.00% 1 Missing ⚠️
... and 2 more

❌ Your project check has failed because the head coverage (56.80%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1343      +/-   ##
==========================================
- Coverage   56.82%   56.80%   -0.03%     
==========================================
  Files         647      646       -1     
  Lines       36736    36791      +55     
==========================================
+ Hits        20875    20898      +23     
- Misses      15206    15235      +29     
- Partials      655      658       +3     
Files with missing lines Coverage Δ
api/types/repo.go 99.23% <100.00%> (+0.02%) ⬆️
database/repo/table.go 100.00% <ø> (ø)
database/types/repo.go 90.04% <100.00%> (+0.09%) ⬆️
mock/server/repo.go 0.00% <ø> (ø)
scm/github/github.go 51.68% <ø> (ø)
scm/github/merge_queue.go 100.00% <100.00%> (ø)
api/build/auto_cancel.go 35.16% <0.00%> (+18.23%) ⬆️
compiler/native/compile.go 72.29% <0.00%> (ø)
router/build.go 0.00% <0.00%> (ø)
api/build/update.go 0.00% <0.00%> (ø)
... and 8 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ecrupper ecrupper self-assigned this Aug 28, 2025
@ecrupper ecrupper added the v0.28 label Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants