-
Notifications
You must be signed in to change notification settings - Fork 30
feat(events)!: support merge queue for GitHub SCM #1343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ecrupper
wants to merge
14
commits into
main
Choose a base branch
from
feat/merge-queue
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
❌ Your project check has failed because the head coverage (56.80%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1343 +/- ##
==========================================
- Coverage 56.82% 56.80% -0.03%
==========================================
Files 647 646 -1
Lines 36736 36791 +55
==========================================
+ Hits 20875 20898 +23
- Misses 15206 15235 +29
- Partials 655 658 +3
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: go-vela/community#1061
Breaking Changes
merge_queue_events, which will be a list of events that themerge_groupevent build will report to. This is necessary to preserve normal required status checks while also allowing for a merge queue. Vela is event-based in its status checks, not job-name-based. So required checks from apull_requestbuild will need to be targeted formerge_groupevents.Opt In
Ultimately, this is opt-in functionality. If users do not supply any override events, then Vela will behave the exact same.
Pipeline Changes
Auto Cancel
Determining stale builds for a merge group is different than normal builds. Stale builds are defined as builds that are
pendingorrunningthat are part of the merge group and also include a build that failed. There's a more detailed description of this in the reference link.