Skip to content

Conversation

@timhuynh94
Copy link
Contributor

@timhuynh94 timhuynh94 commented Apr 9, 2025

This branch is the combined working branch for development purposes, but will be closed in lieu of separate pr's (currently in draft) when ready, to allow for smaller pr's:

  • storage addition
  • test_report key functionality
  • database functionality

TimHuynh and others added 30 commits December 12, 2024 09:41
* refactor(pipeline): use server API types for pipeline and migrate compiler types

* gci

* feat: add sender rule for pipelines

---------

Co-authored-by: David May <[email protected]>
* chore(lint): address existing linter issues

* remove dupl from exclusion list
* enhance(build): add fork field for OIDC

* fix test

* integration test update
* enhance(yaml): allow for users to parse pipelines using old library

* testing file for internal yaml

* chore(compiler): convert unmarshaled buildkite to go-yaml

* remove tests used in later PRs

* lintfix

* fix schema

* gci
* init commit

* feat(repo): add pending approval timeout

* fix test

* remove dead code

---------

Co-authored-by: David May <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

golangci

🚫 [golangci] reported by reviewdog 🐶
missing whitespace above this line (invalid statement above assign) (wsl_v5)

_ = json.Unmarshal(data, &body)


🚫 [golangci] reported by reviewdog 🐶
unnecessary whitespace (trailing-whitespace) (wsl_v5)


🚫 [golangci] reported by reviewdog 🐶
unnecessary whitespace (trailing-whitespace) (wsl_v5)


🚫 [golangci] reported by reviewdog 🐶
unnecessary whitespace (trailing-whitespace) (wsl_v5)


🚫 [golangci] reported by reviewdog 🐶
missing whitespace above this line (no shared variables above if) (wsl_v5)

if resp.Code != http.StatusOK {


🚫 [golangci] reported by reviewdog 🐶
missing whitespace above this line (no shared variables above if) (wsl_v5)

if resp.Code != http.StatusOK {


🚫 [golangci] reported by reviewdog 🐶
missing whitespace above this line (no shared variables above if) (wsl_v5)

if resp.Code != http.StatusOK {


🚫 [golangci] reported by reviewdog 🐶
missing whitespace above this line (too many statements above defer) (wsl_v5)

fake := httptest.NewServer(engine)


🚫 [golangci] reported by reviewdog 🐶
missing whitespace above this line (too many statements above defer) (wsl_v5)

fake := httptest.NewServer(engine)


🚫 [golangci] reported by reviewdog 🐶
missing whitespace above this line (no shared variables above expr) (wsl_v5)

c.Stream(func(w io.Writer) bool {


🚫 [golangci] reported by reviewdog 🐶
missing whitespace above this line (invalid statement above expr) (wsl_v5)

c.XML(http.StatusOK, objects)


🚫 [golangci] reported by reviewdog 🐶
missing whitespace above this line (too many statements above defer) (wsl_v5)

fake := httptest.NewServer(engine)


🚫 [golangci] reported by reviewdog 🐶
missing whitespace above this line (no shared variables above range) (wsl_v5)

for _, name := range results {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants