Skip to content

Usable error message with value and pattern for RegExp errors #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: v2
Choose a base branch
from
Open

Usable error message with value and pattern for RegExp errors #55

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8077143
adding error message with pattern for RegExp errors
bieli Mar 23, 2017
0e6b6be
adding error message with pattern for RegExp errors and inputer value
bieli Mar 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion builtins.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ func regex(v interface{}, param string) error {
}

if !re.MatchString(s) {
return ErrRegexp
return TextErr{errors.New(fmt.Sprintf("regular expression mismatch - value: '%s', expected pattern: '%s'", s, param))}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could use fmt.Errorf instead of error.New(fmt.Sprintf(...

}
return nil
}
Expand Down