adjust auto rollup for CH 25.8 (int64 no longer is a string in json) #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hedius
force-pushed
the
ch-25_8-remote-rollup-fix
branch
from
f4f5c8e to
22061be
Compare
|
Not sure why the pipeline failed? The code seems to work. Is what I did correct? |
Hipska
suggested changes
Sep 30, 2025
| Age string `json:"age"` | ||
| Precision string `json:"precision"` | ||
| Age uint64 `json:"age"` | ||
| Precision uint64 `json:"precision"` |
There was a problem hiding this comment.
What about the ones still using CH pre 25.8? I think the best is to set output_format_json_quote_64bit_integers to false on the connection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #321
not tested atm.
This PR modifies the struct rollupRulesResponseRecord to use int64 for age and precision.
At the moment this is a string. With ClickHouse 25.8 this is now an integer in the JSON.