Skip to content

Fix logger/slog output source file depth is incorrect #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix logger/slog output source file depth is incorrect #833

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
package main

import (
"bytes"
"context"
"log/slog"
"strings"
"testing"
"time"

"gorm.io/playground/models"
)
Expand All @@ -21,6 +26,24 @@ func TestGORM(t *testing.T) {
}
}

func TestSlogLogger(t *testing.T) {
buf := &bytes.Buffer{}
handler := slog.NewTextHandler(buf, &slog.HandlerOptions{AddSource: true})
logger := NewSlogLogger(slog.New(handler), Config{LogLevel: Info})

logger.Trace(context.Background(), time.Now(), func() (string, int64) {
return "select count(*) from users", 0
}, nil)

if strings.Contains(buf.String(), "gorm/logger/slog.go") {
t.Error("Found internal slog.go reference in caller frame. Expected only test file references.")
}

if !strings.Contains(buf.String(), "main_test.go") {
t.Error("Missing expected test file reference. 'main_test.go' should appear in caller frames.")
}
}

// func TestGORMGen(t *testing.T) {
// user := models.User{Name: "jinzhu2"}
// ctx := context.Background()
Expand Down
Loading