Skip to content

Add --color-logo, matching the logo's primary color #34639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 7, 2025
Merged

Add --color-logo, matching the logo's primary color #34639

merged 4 commits into from
Jun 7, 2025
+4 −2

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Jun 7, 2025 •
edited
Loading

Add a new color that indicates the logo's primary color and use it in the frontpage over previous green color. This will be useful for customization.

Screenshot 2025-06-07 at 16 53 34

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 7, 2025
@wxiaoguang
Copy link
Contributor

It seems inconsistent with the green logo.

IIRC the "green" links were done intentionally

@silverwind
Copy link
Member Author

The logo could be customized. Maybe we should introduce a --color-logo and make it match the logo green exactly. That way, the user can control this color for customization.

@silverwind
Copy link
Member Author

Added:

Screenshot 2025-06-07 at 16 53 34

@silverwind silverwind changed the title Make home page use primary color Add --color-logo for text to match logo color Jun 7, 2025
@silverwind silverwind changed the title Add --color-logo for text to match logo color Add --color-logo for text that should match logo color Jun 7, 2025
wxiaoguang
wxiaoguang approved these changes Jun 7, 2025
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the PR's description could also be updated accordingly?

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 7, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 7, 2025
@silverwind
Copy link
Member Author

OP updated

@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 7, 2025
@silverwind silverwind enabled auto-merge (squash) June 7, 2025 17:58
@silverwind silverwind changed the title Add --color-logo for text that should match logo color Add --color-logo, matching the logo's color Jun 7, 2025
@silverwind silverwind changed the title Add --color-logo, matching the logo's color Add --color-logo, matching the logo's primary color Jun 7, 2025
@silverwind silverwind merged commit 7fa5a88 into go-gitea:main Jun 7, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.25.0 milestone Jun 7, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 7, 2025
@wxiaoguang wxiaoguang deleted the homeprimary branch June 7, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.
4 participants
@silverwind @wxiaoguang @delvh @GiteaBot