Fix footnote jump behavior on the issue page. #34621
Open
+63
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
charles7668
force-pushed
the
fix/issue_footnote
branch
from
11b5171 to
a322a88
Compare
lunny
reviewed
Jun 6, 2025
|
It's better to have a test. |
|
Related to #34590 |
charles7668
force-pushed
the
fix/issue_footnote
branch
from
a322a88 to
98eb32c
Compare
charles7668
force-pushed
the
fix/issue_footnote
branch
from
47b1613 to
1c232e4
Compare
charles7668
force-pushed
the
fix/issue_footnote
branch
from
1c232e4 to
ff9efed
Compare
lunny
reviewed
Jun 7, 2025
| @@ -320,6 +320,8 @@ func visitNode(ctx *RenderContext, procs []processor, node *html.Node) *html.Nod | |||
| } | |||
|
|
|||
| processNodeAttrID(node) | |||
| processFootnoteID(ctx, node) | |||
There was a problem hiding this comment.
Perhaps we can merge these two functions, as they aren't used elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #34511
Close #34590
Add comment ID to the footnote item's id attribute to ensure uniqueness.