Skip to content

Add issue delete notifier #34592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

badhezi
Copy link
Contributor

@badhezi badhezi commented Jun 3, 2025

Fixes #34591

A reference regarding the deletion of issue webhooks on GitHub: https://docs.github.com/en/webhooks/webhook-events-and-payloads?actionType=deleted#issues

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 3, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jun 3, 2025
@badhezi badhezi marked this pull request as ready for review June 3, 2025 07:10
@lunny
Copy link
Member

lunny commented Jun 3, 2025

A webhook integration test is necessary. Since there are many examples, it's not too difficult. You can add a test function at https://github.com/go-gitea/gitea/blob/main/tests/integration/repo_webhook_test.go
It's better to have a ref links to github's webhook docs in the pull request content.

@lunny lunny added this to the 1.25.0 milestone Jun 3, 2025
@lunny lunny added the type/enhancement An improvement of existing functionality label Jun 3, 2025
@badhezi
Copy link
Contributor Author

badhezi commented Jun 4, 2025

A webhook integration test is necessary. Since there are many examples, it's not too difficult. You can add a test function at https://github.com/go-gitea/gitea/blob/main/tests/integration/repo_webhook_test.go It's better to have a ref links to github's webhook docs in the pull request content.

I added tests for both issue and pull request delete.

It's better to have a ref links to github's webhook docs in the pull request content.

I didn't quite understand what you meant by that, can you explain?

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 4, 2025
@lunny
Copy link
Member

lunny commented Jun 4, 2025

A webhook integration test is necessary. Since there are many examples, it's not too difficult. You can add a test function at https://github.com/go-gitea/gitea/blob/main/tests/integration/repo_webhook_test.go It's better to have a ref links to github's webhook docs in the pull request content.

I added tests for both issue and pull request delete.

It's better to have a ref links to github's webhook docs in the pull request content.

I didn't quite understand what you meant by that, can you explain?

I updated the content and add a reference link to github's webhook documentation directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/go Pull requests that update Go code modifies/translation type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deletion of issue does not trigger webhook
3 participants