-
Notifications
You must be signed in to change notification settings - Fork 109
Create files to support NSMovie and NSMovieView #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…nges, and config.make/config.h changes
Completely revamped and simplified. |
…GSMovieView move decoding entirely to threads
This reverts commit 02a258d.
@rfm Please take a look at this one as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR creates comprehensive NSMovie and NSMovieView implementation using FFmpeg as the underlying multimedia framework. The implementation adds video playback functionality with synchronized audio/video rendering and proper build system integration.
- Adds complete NSMovie and NSMovieView classes with FFmpeg-based video/audio decoding capabilities
- Implements GSMovieView as a subclass providing the actual playback functionality with audio-video synchronization
- Integrates FFmpeg dependencies into the build system with proper configuration and library detection
Reviewed Changes
Copilot reviewed 17 out of 18 changed files in this pull request and generated 5 comments.
Show a summary per file
File | Description |
---|---|
configure.ac | Adds FFmpeg library detection and build configuration for NSMovie/NSMovieView |
config.make.in | Defines build variables for movie and sound library support |
Source/NSSound.m | Updates NSSound implementation with improved memory management |
Source/NSMovieView.m | Basic NSMovieView implementation with stubs for most functionality |
Source/NSMovie.m | NSMovie class implementation with data handling and codec integration |
Source/GSMovieView.m | Complete video player implementation with FFmpeg integration |
Source/GSAudioPlayer.* | Audio player class for synchronized audio playback |
Source/GSAVUtils.* | Utility functions for AVPacket/NSDictionary conversion |
Headers/AppKit/NSMovie*.h | Public API headers with comprehensive documentation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
I think this is as close to done as I can get it. It works. I would like others to have the opportunity to look at and fix the code on this. Please review and approve if you can @rfm or @fredkiefer |
implementation for NSMovie and NSMovieView. The tests for this are here:
https://github.com/gcasa/NSMovie_test
https://github.com/gcasa/apps-videoplayer