Text changes and translations #2007
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying gmx-interface with
|
| Latest commit: |
d7063da
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3596481d.gmx-interface.pages.dev |
| Branch Preview URL: | https://text-changes.gmx-interface.pages.dev |
Deploying gmx-interface-home with
|
| Latest commit: |
d7063da
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://48c5587c.gmx-interface-home.pages.dev |
| Branch Preview URL: | https://text-changes.gmx-interface-home.pages.dev |
qwinndev
requested changes
Oct 31, 2025
| title={t`Rank`} | ||
| width={6} | ||
| tooltip={ | ||
| <Trans values={{ minCollateral: formatUsd(MIN_COLLATERAL_USD_IN_LEADERBOARD, { displayDecimals: 0 }) }}> |
There was a problem hiding this comment.
2 problems:
- we do not use such value substitution in our code
- eslint will raise error here, because component for value created each render
to resolve it just use value directly in position of {{ minCollateral }}
example in our codebase:
| title={t`Rank`} | ||
| width={6} | ||
| tooltip={ | ||
| <Trans values={{ minCollateral: formatUsd(MIN_COLLATERAL_USD_IN_LEADERBOARD, { displayDecimals: 0 }) }}> |
There was a problem hiding this comment.
issue with value substitution
src/components/TradeBox/TradeBox.tsx
Outdated
| The actual execution price may differ from the set limit price due to fees and price impact. This | ||
| ensures that you receive at least the minimum receive amount. | ||
| The execution price may differ from the set limit price due to fees and price impact. This | ||
| ensures that you receive at least the minimum receive amount. <a href="https://docs.gmx.io/docs/trading/v2/#limit-orders">Read more</a>. |
There was a problem hiding this comment.
better is use ExternalLink component with newTab prop (to open in new window) and then verify how it looks
| collateralTokenPriceMax, | ||
| initialCollateralToken, | ||
| totalImpactUsd, | ||
| totalImpactUsd = 0n, |
There was a problem hiding this comment.
are you sure in this change? not expected to see it text changes and translations
There was a problem hiding this comment.
r87 vs master change, not mine. i will change target to r88 once created
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.