Skip to content

fe_design_w_market_surrogate_files #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nareshsusarla
Copy link
Contributor

Addresses issue:

Summary/Motivation:

This PR adds files for FE case design using market surrogates

Changes proposed in this PR:

  • adds the multiperiod design flowsheet for FE case
  • adds keras surrogate models
  • adds json files for scaling factors, representative days, and capacity factors

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.md and COPYRIGHT.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (63bc59c) 93.69% compared to head (7282460) 93.69%.
Report is 28 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #170   +/-   ##
=======================================
  Coverage   93.69%   93.69%           
=======================================
  Files          59       59           
  Lines        7104     7104           
=======================================
  Hits         6656     6656           
  Misses        448      448           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ksbeattie ksbeattie added the Priority:Normal Medium Priority Issue or PR label Dec 19, 2022
@ksbeattie
Copy link
Contributor

ksbeattie commented Mar 13, 2023

This is related to (similar problem) PR #179

@ksbeattie ksbeattie added Priority:High High Priority Issue or PR and removed Priority:Normal Medium Priority Issue or PR labels Apr 10, 2023
@lbianchi-lbl
Copy link
Contributor

This might have to wait until ~1st week of June but is still planned to be in the June release.

@lbianchi-lbl
Copy link
Contributor

This might have to wait until ~1st week of June but is still planned to be in the June release.

This still applies.

@lbianchi-lbl
Copy link
Contributor

@nareshsusarla any updates on this? It would have to be merged within the next few days for it to be in the June release.

@ksbeattie
Copy link
Contributor

This will not be for the June/Final release.

@adowling2
Copy link
Contributor

@nareshsusarla, please instead merge this into a non-main branch. Also include notes on next steps/why we pivoted from this

@nareshsusarla
Copy link
Contributor Author

A different PR #216 is created to merge these files with a feature branch. So, this PR is now closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants