Skip to content

Conversation

@greenozon
Copy link

@greenozon greenozon commented Jul 12, 2025

the subject
also some other minor cleanups to make compiler happy..
+memory leaks (mainly in dtors)

@glmcdona
Copy link
Owner

Super cool, thanks @greenozon. Will have a closer look through this PR this week.

@greenozon
Copy link
Author

Thanks for reply!
there are still like hundred warnings but majority are due to comparing signed/unsigned numbers... (addresses mainly)

@greenozon
Copy link
Author

greenozon commented Jul 14, 2025

Current stats as from last commit:

78 warnings for Win32 config (diff modules)
46 warnings for Win64 config (all in a single module - pe_header.cpp)

@greenozon
Copy link
Author

The last commit benefits from low memory fragmentation as each & every new/delete does fragment RAM as well as has extra overhead for computation for new/delete operators...
also we do not need delete/delete[] - those sometimes might be omitted (-> memleak) or in case of exception - hard to delete as well.
when we create objects on stack - we have full guarantee that it'll be freed in any case.

@greenozon
Copy link
Author

@glmcdona could you please give me a hint here -
image

IMHO the condition should be > 0... ?

@greenozon
Copy link
Author

question:

image

seems this option ReconstructHeaderAsDll is never set (did not find any code for setting it to true)
and second point - according to comments it's doing things vice versa?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants