feat: smooth scrolling #87
Open
+5
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobzim-stl
force-pushed
the
jacob/smooth-scroll
branch
from
6de4072 to
c738448
Compare
jacobzim-stl
force-pushed
the
jacob/smooth-scroll
branch
from
c738448 to
79fc0eb
Compare
|
What are the cases that scrollTo doesn't work? |
|
Try it on a PDF, that was the worst case for me, but it would also just break randomly. |
|
Also ty! but fwiw I don't want to introduce this change without a It'd also be very cool to have a popup for existing users that mentions this change when they try to scroll for the first time again. (but I don't know exactly how that would work rn) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You said this would be hard, and it seems like you've hit edge cases with this in the past.
I couldn't repro the edge cases and it seems to just work for me.
Just OOC were you testing page-level scrolling (as in , )?
I noticed that the full page scrolling was happening very very slowly before.