Skip to content

Conversation

@jacobzim-stl
Copy link
Collaborator

Fixes #74

@jacobzim-stl
Copy link
Collaborator Author

What's the thinking behind glide vs GlideBrowser.api?

@RobertCraigie
Copy link
Contributor

glide shouldn't actually work in the browser internals, you have to use GlideBrowser.api instead.

tbh I have no idea how the tests were seeming to work when you were running it earlier, maybe you didn't have pnpm dev running?

@RobertCraigie RobertCraigie changed the title feat(hints): elide hints for conflicting keymaps fix(hints): do not generate hint labels for conflicting keymaps Oct 18, 2025
Copy link
Contributor

@RobertCraigie RobertCraigie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice

@RobertCraigie RobertCraigie merged commit d84334d into main Oct 18, 2025
3 checks passed
@RobertCraigie RobertCraigie deleted the jacob/elide-hints branch October 18, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not include hint labels for keymaps defined in hint mode

3 participants