Skip to content

Update variables in app.yml to actions_variables #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 15, 2025

Conversation

a-magdy
Copy link
Contributor

@a-magdy a-magdy commented Apr 14, 2025

No description provided.

@Copilot Copilot AI review requested due to automatic review settings April 14, 2025 22:11
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

app.yml:119

  • [nitpick] Consider updating the inline comment above to reflect the new key name and purpose. This will help maintain consistency between the documentation and configuration.
actions_variables: write

@a-magdy
Copy link
Contributor Author

a-magdy commented Apr 14, 2025

Tried running the latest code and was getting this error when I use the manifest to create a new app:

Screenshot 2025-04-15 at 00 41 43

After few trials I figured that this changes doesn't cause any errors, haven't tested it fully yet to check that this covers the implementation of the existing setup

Copy link
Collaborator

@decyjphr decyjphr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@decyjphr decyjphr merged commit e315287 into github:main-enterprise Apr 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants