Avoid double counting outside collaborators, preventing deletions #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (3)
lib/plugins/diffable.js:93
- Ensure that JSON.stringify is used consistently for logging all objects to maintain clear and accurate debug output.
this.log.debug(`Results of comparing ${this.constructor.name} diffable target ${JSON.stringify(existingRecords)} with source ${JSON.stringify(filteredEntries)} is ${JSON.stringify(results)}`)
lib/plugins/diffable.js:95
- Verify that using 'this.repo.repo' is correct regarding the structure of the repo object, ensuring consistency with related usages elsewhere in the code.
this.log.debug(`There are no changes for ${this.constructor.name} for repo ${this.repo.repo}. Skipping changes`)
lib/plugins/collaborators.js:23
- Confirm that removing the API call for 'outside' affiliation fully prevents double counting while still capturing all necessary collaborator data.
return Promise.all([this.github.repos.listCollaborators({ repo: this.repo.repo, owner: this.repo.owner, affiliation: 'direct' }),
|
@decyjphr this one took me a while to track down, but the answer turned out to be in the REST docs if read very carefully |
klutchell
force-pushed
the
balena/dedupe-collaborators
branch
from
6550558 to
ce15e59
Compare
|
Oops, caught the failing test too. Thanks @decyjphr ! |
|
Looks good! Once your code has the latest from the base I can merge. |
Signed-off-by: Kyle Harding <[email protected]>
The 'direct' affiliation of collaborators includes the 'outside' collaborators, and in testing when the resulting source contained duplicates the test function was not deleting collaborators. Signed-off-by: Kyle Harding <[email protected]>
klutchell
force-pushed
the
balena/dedupe-collaborators
branch
from
ce15e59 to
fd4af7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'direct' affiliation of collaborators includes the 'outside' collaborators,
and in testing when the resulting source contained duplicates the test
function was not deleting collaborators.