Skip to content

fix: ensure created_at shows up in json #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2025
Merged

Conversation

jmeridth
Copy link
Member

@jmeridth jmeridth commented Mar 16, 2025

Additional fixes for #489

  • Handle json output of created_at
  • update git version installed in image

Pull Request

Proposed Changes

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, maintenance, or breaking

@jmeridth jmeridth self-assigned this Mar 16, 2025
@Copilot Copilot AI review requested due to automatic review settings March 16, 2025 03:27
@jmeridth jmeridth requested a review from a team as a code owner March 16, 2025 03:27
@github-actions github-actions bot added the fix label Mar 16, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR ensures that the created_at attribute is included in the JSON output for issues. The changes update both the JSON writer function and its corresponding tests.

  • Added the created_at field to the JSON output in json_writer.py.
  • Updated test_json_writer.py to include created_at in input test cases and expected outputs.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
test_json_writer.py Added created_at parameter in issue objects and expected JSON.
json_writer.py Updated JSON output to include the created_at field.

Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more

- [x] update git version installed in image

Signed-off-by: jmeridth <[email protected]>
@jmeridth jmeridth force-pushed the jm_created_at_json branch from d317f24 to fa5f0ca Compare March 16, 2025 09:22
@jmeridth jmeridth merged commit ed6e4b2 into main Mar 16, 2025
34 checks passed
@jmeridth jmeridth deleted the jm_created_at_json branch March 16, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant