-
Notifications
You must be signed in to change notification settings - Fork 572
Adding SecretScanning Toolset #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
d31dd8b
to
6c01bf9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new secret scanning toolset to the MCP server by adding two new commands: GetSecretScanningAlert and ListSecretScanningAlerts.
- Integrates secret scanning tools into the toolset initialization in pkg/github/tools.go.
- Implements secret scanning functionalities in pkg/github/secret_scanning.go with accompanying tests in pkg/github/secret_scanning_test.go.
- Updates the README.md with usage documentation for the new secret scanning endpoints.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
pkg/github/tools.go | Registers the secret scanning tools into the toolset collection. |
pkg/github/secret_scanning_test.go | Provides tests ensuring correct behavior of the secret scanning tool handlers. |
pkg/github/secret_scanning.go | Implements the GetSecretScanningAlert and ListSecretScanningAlerts functions. |
README.md | Adds documentation detailing the usage of the new secret scanning tools. |
Did a manual test run:
|
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks great, just a couple of small comments.
|
||
# Go | ||
vendor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vendor | |
vendor | |
@@ -73,6 +73,11 @@ func InitToolsets(passedToolsets []string, readOnly bool, getClient GetClientFn, | |||
toolsets.NewServerTool(GetCodeScanningAlert(getClient, t)), | |||
toolsets.NewServerTool(ListCodeScanningAlerts(getClient, t)), | |||
) | |||
secretSecurity := toolsets.NewToolset("secret_security", "Secret security related tools, such as GitHub Secret Scanning"). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is actually called secret protection. https://github.blog/changelog/2025-03-04-introducing-github-secret-protection-and-github-code-security/
We just split the security products, otherwise I'd have called it all Advanced Security or ghas.
This PR adds: