Skip to content

enhancement: add tool to request reviewers for pull requests #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MayorFaj
Copy link
Contributor

This pull request introduces a new feature to request reviewers for a pull request in the GitHub MCP tool. The changes include updates to the documentation, implementation of the new tool, and corresponding tests. Below are the most important changes:

New Feature Implementation:

  • pkg/github/pullrequests.go: Added the RequestPullRequestReviewers function to create a tool for requesting reviewers for a pull request. This includes defining the tool's input schema, extracting parameters, and making the API call to GitHub.

Documentation Updates:

  • README.md: Updated to include documentation for the new request_pull_request_reviewers tool, detailing its parameters and usage. [1] [2]

Test Cases:

  • pkg/github/pullrequests_test.go: Added tests for the new RequestPullRequestReviewers function to verify the tool definition and various scenarios, including successful requests and error handling.

Server Integration:

  • pkg/github/server.go: Integrated the new RequestPullRequestReviewers tool into the server setup, ensuring it is available for use.

Closes: #259

@Copilot Copilot AI review requested due to automatic review settings April 14, 2025 15:06
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

@juruen
Copy link
Collaborator

juruen commented Apr 15, 2025

@MayorFaj thank you again for your time working on this project!

I have a suggestion, instead of creating a new tool, we could leverage the existing update_pull_request tool to also take the reviewers as an optional parameter.

Is that something that you'd like to explore? Otherwise, I can take a stab at it when I have the time.

Thanks!

@MayorFaj
Copy link
Contributor Author

Sure will take a look

@MayorFaj MayorFaj changed the title feat: add tool to request reviewers for pull requests enhancement: add tool to request reviewers for pull requests Apr 15, 2025
@MayorFaj
Copy link
Contributor Author

@juruen I made a new PR #285. Kindly review when you get the chance to. I am going to close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add functionality to assign reviewers to pull requests
3 participants