feat: add token source flag, gh cli auth #231
Open
+61
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gillisandrew
requested review from
juruen,
SamMorrowDrums,
williammartin and
toby
as code owners
gillisandrew
force-pushed
the
feat-gh-cli-auth
branch
from
89d4dae to
91fcecd
Compare
gillisandrew
changed the title
There was a problem hiding this comment.
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- go.mod: Language not supported
Comments suppressed due to low confidence (1)
cmd/github-mcp-server/main.go:227
- [nitpick] The variable name 'token_source' does not follow Go naming conventions. Renaming it to 'tokenSource' would improve readability and adhere to idiomatic Go style.
token_source := viper.GetString("token-source")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for using the GitHub CLI's token. Users pass
--token-source ghto enable it (defaulting to "env" token source). It also includes a couple of changes that should make it straightforward to publish a GitHub CLI extension (#215) that uses "gh" as the default source.