Enable caching of npm install/npm ci for setup-node action
#1457
+16
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm copying the setup of one of these actions to another repo, and the hardcoding of ref surprised me... these should be the same as the defaault behavior. I checked with Barry who originally committed these files, and he didn't remember why... possibly he'd hardcoded them when testing the action and forgot to remove them. So let's pull them out to remove confusion.
The `setup-node` action now supports caching the results of `npm install`/`npm ci`: https://github.blog/changelog/2021-07-02-github-actions-setup-node-now-supports-dependency-caching/
There was a problem hiding this comment.
Pull Request Overview
This PR enables caching for npm dependencies in GitHub Actions workflows by leveraging the setup-node action's new caching support.
- Enables caching for npm commands by adding "cache: 'npm'" to the setup-node action.
- Simplifies workflow steps by removing the redundant "name: Setup Node.js" fields.
- Applies changes consistently across multiple workflow configuration files.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/test.yml | Updated setup-node step to cache npm dependencies |
| .github/workflows/integration-test.yml | Added caching for npm in the setup-node step |
| .github/workflows/dependabot-build.yml | Enabled npm caching and removed explicit step name |
| .github/workflows/check-dist.yml | Applied caching configuration for npm dependencies |
Comments suppressed due to low confidence (4)
.github/workflows/test.yml:16
- [nitpick] Consider adding an explicit step name (e.g., 'Setup Node.js with caching') to improve clarity in workflow logs.
- uses: actions/setup-node@v4
.github/workflows/integration-test.yml:20
- [nitpick] Adding a descriptive step name for the setup-node action can enhance the readability of the workflow logs.
- uses: actions/setup-node@v4
.github/workflows/dependabot-build.yml:37
- [nitpick] Consider reintroducing a step name for the setup-node action to make the workflow easier to navigate in logs.
- uses: actions/setup-node@v4
.github/workflows/check-dist.yml:17
- [nitpick] It might be beneficial to add a step name for clarity in the workflow log outputs, such as 'Setup Node.js with cache enabled'.
- uses: actions/setup-node@v4
jeffwidman
force-pushed
the
remove-unneeded-ref-hardcoding
branch
from
21e2530 to
d1a760e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
setup-nodeaction now supports caching the results ofnpm install/npm ci:https://github.blog/changelog/2021-07-02-github-actions-setup-node-now-supports-dependency-caching/