Remove unnecessary hardcoding of ref
#1456
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the unnecessary hardcoding of the "ref" parameter in the workflow files to rely on the default behavior of the actions/checkout.
- Remove the "ref" parameter from the checkout step in .github/workflows/test.yml
- Remove the "ref" parameter from the checkout step in .github/workflows/check-dist.yml
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/test.yml | Removed hardcoded "ref" in the checkout step to use default behavior |
| .github/workflows/check-dist.yml | Removed hardcoded "ref" in both the checkout and the subsequent step to use default behavior |
I'm copying the setup of one of these actions to another repo, and the hardcoding of ref surprised me... these should be the same as the defaault behavior. I checked with Barry who originally committed these files, and he didn't remember why... possibly he'd hardcoded them when testing the action and forgot to remove them. So let's pull them out to remove confusion.
jeffwidman
force-pushed
the
remove-unneeded-ref-hardcoding
branch
from
21e2530 to
d1a760e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying dependabot/fetch-metadata#617 over here: