Skip to content

Remove dialog-toggle-events polyfill #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025

Conversation

jibrang
Copy link
Contributor

@jibrang jibrang commented Apr 14, 2025

The purpose of this PR is to remove the dialog-toggle-events-polyfill from the package. This code change is necessary because the polyfill is disrupting the browser error reporting in old versions of Firefox.
I will test this code change in review-lab before attempting the upgrade in Dotcom.

I verified the dialog-toggle-events polyfill is not used in any other place in the browser-support package and Doctom:

@Copilot Copilot bot review requested due to automatic review settings April 14, 2025 19:08
@jibrang jibrang requested a review from a team as a code owner April 14, 2025 19:08
@jibrang jibrang requested a review from dgreif April 14, 2025 19:08
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the dialog-toggle-events polyfill to resolve browser error reporting issues in an older version of Firefox.

  • Removed import of dialog-toggle-events
  • Adjusted the polyfills object and simplified the isSupported() function to return only baseSupport
Files not reviewed (1)
  • package.json: Language not supported
Comments suppressed due to low confidence (1)

src/index.ts:59

  • [nitpick] The isSupported() function now only checks baseSupport after removing the dialog-toggle-events polyfill. Please confirm that this simplification is intended and that support checks for the remaining polyfills can be safely omitted.
return baseSupport

@jibrang jibrang force-pushed the jibrang/remove-dialog-toggle-events branch from b02f2f7 to bf119cd Compare April 14, 2025 19:10
Copy link
Contributor

@dgreif dgreif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing this for now. We probably need to cut a major release since this is technically a breaking change

@jibrang jibrang merged commit c616162 into main Apr 14, 2025
5 checks passed
@jibrang jibrang deleted the jibrang/remove-dialog-toggle-events branch April 14, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants