Skip to content

BUGFIX: 3-arg subtraction was not implemented. #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

BUGFIX: 3-arg subtraction was not implemented. #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ebb999
BUGFIX: 3-arg subtraction was not implemented.
Oct 7, 2022
1794d68
Add support for third arg in subtraction
prdriscoll Oct 7, 2022
6458d2e
Apply suggestions from code review
prdriscoll Oct 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/calc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,13 @@ def add(a, b, third_operand = 0):
"""
return a + b + third_operand

def sub(a, b):
def sub(a, b, x = 0):
"""
Subtract some numbers

```py
sub(8, 3) # 5
sub(8, 3, 10) # -5
```
"""
return a - b
return a - b - x
2 changes: 2 additions & 0 deletions src/calc_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ def test_sub_2arg(self):
# Make sure 4 - 3 = 1
self.assertEqual(sub(4, 3), 1, 'subtracting three from four')

def test_sub_3arg(self):
self.assertEqual(sub(4, 3, 1), 0, 'subtracting three and one from four')

if __name__ == '__main__':
unittest.main()