Skip to content

Conversation

@jeanlucthumm
Copy link

@jeanlucthumm jeanlucthumm commented Sep 4, 2025

Summary

Changes

  • Added database parameter to MCP server Neo4jConfig class with environment variable parsing
  • Updated Graphiti main class constructor to accept and pass through database parameter
  • Added integration test to verify database parameter functionality
  • Updated documentation in .env.example files and README.md to clarify Neo4j Enterprise requirement

Notes

  • Feature is Neo4j-specific as other drivers have different database configuration approaches
  • Custom database names require Neo4j Enterprise Edition (not supported in Community Edition)

Important

Add support for configurable Neo4j database names via NEO4J_DATABASE environment variable, with updates to configuration, constructors, tests, and documentation.

  • Environment Variable Support:
    • Add NEO4J_DATABASE environment variable for configurable Neo4j database names.
    • Update Neo4jConfig in graphiti_mcp_server.py to parse NEO4J_DATABASE.
  • Constructor Changes:
    • Update Graphiti constructor in graphiti.py to accept database parameter.
    • Pass database parameter to Neo4jDriver.
  • Testing:
    • Add integration test test_graphiti_neo4j_database_parameter in test_graphiti_int.py.
  • Documentation:
    • Update .env.example files and README.md to document NEO4J_DATABASE usage and Neo4j Enterprise requirement.

This description was created by Ellipsis for 08df73a. You can customize this summary. It will automatically update as commits are pushed.

@danielchalef
Copy link
Member

danielchalef commented Sep 4, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@jeanlucthumm
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@jeanlucthumm
Copy link
Author

recheck

danielchalef added a commit that referenced this pull request Sep 4, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 08df73a in 1 minute and 29 seconds. Click for details.
  • Reviewed 169 lines of code in 8 files
  • Skipped 0 files when reviewing.
  • Skipped posting 7 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .env.example:7
  • Draft comment:
    The added NEO4J_DATABASE variable comment is clear. Ensure it remains consistent with our Enterprise-only usage notice.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 80% None
2. README.md:272
  • Draft comment:
    Updated Neo4j documentation clearly notes that custom database names require Enterprise edition. Ensure consistency with driver usage details.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 80% None
3. graphiti_core/graphiti.py:188
  • Draft comment:
    Consider replacing 'database or "neo4j"' with a check against None (e.g. 'database if database is not None else "neo4j"') to avoid unintentionally overriding an empty string. Also, verify that a copyright header is present.
  • Reason this comment was not posted:
    Confidence changes required: 66% <= threshold 80% None
4. mcp_server/graphiti_mcp_server.py:464
  • Draft comment:
    Good integration of the 'database' parameter in Neo4jConfig and its env parsing. Ensure the file includes the required copyright header.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 80% None
5. server/.env.example:5
  • Draft comment:
    The consistent comment for NEO4J_DATABASE is maintained here. No changes needed.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 80% None
6. tests/test_graphiti_int.py:78
  • Draft comment:
    The new integration test for the Neo4j 'database' parameter is comprehensive. Optionally, consider asserting that the specified database is used during queries if feasible.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 80% None
7. uv.lock:2
  • Draft comment:
    Version bump update from 0.20.0 to 0.20.1 is noted. Ensure that versioning is managed correctly with other related changes.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 80% None

Workflow ID: wflow_fdTtRtuWlfaitmqS

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

AIXerum pushed a commit to AIXerum/graphiti that referenced this pull request Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants