-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add NEO4J_DATABASE environment variable support #892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add NEO4J_DATABASE environment variable support #892
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 08df73a in 1 minute and 29 seconds. Click for details.
- Reviewed
169lines of code in8files - Skipped
0files when reviewing. - Skipped posting
7draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .env.example:7
- Draft comment:
The added NEO4J_DATABASE variable comment is clear. Ensure it remains consistent with our Enterprise-only usage notice. - Reason this comment was not posted:
Confidence changes required:0%<= threshold80%None
2. README.md:272
- Draft comment:
Updated Neo4j documentation clearly notes that custom database names require Enterprise edition. Ensure consistency with driver usage details. - Reason this comment was not posted:
Confidence changes required:0%<= threshold80%None
3. graphiti_core/graphiti.py:188
- Draft comment:
Consider replacing 'database or "neo4j"' with a check against None (e.g. 'database if database is not None else "neo4j"') to avoid unintentionally overriding an empty string. Also, verify that a copyright header is present. - Reason this comment was not posted:
Confidence changes required:66%<= threshold80%None
4. mcp_server/graphiti_mcp_server.py:464
- Draft comment:
Good integration of the 'database' parameter in Neo4jConfig and its env parsing. Ensure the file includes the required copyright header. - Reason this comment was not posted:
Confidence changes required:0%<= threshold80%None
5. server/.env.example:5
- Draft comment:
The consistent comment for NEO4J_DATABASE is maintained here. No changes needed. - Reason this comment was not posted:
Confidence changes required:0%<= threshold80%None
6. tests/test_graphiti_int.py:78
- Draft comment:
The new integration test for the Neo4j 'database' parameter is comprehensive. Optionally, consider asserting that the specified database is used during queries if feasible. - Reason this comment was not posted:
Confidence changes required:33%<= threshold80%None
7. uv.lock:2
- Draft comment:
Version bump update from 0.20.0 to 0.20.1 is noted. Ensure that versioning is managed correctly with other related changes. - Reason this comment was not posted:
Confidence changes required:0%<= threshold80%None
Workflow ID: wflow_fdTtRtuWlfaitmqS
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Summary
Changes
databaseparameter to MCP server Neo4jConfig class with environment variable parsingNotes
Important
Add support for configurable Neo4j database names via
NEO4J_DATABASEenvironment variable, with updates to configuration, constructors, tests, and documentation.NEO4J_DATABASEenvironment variable for configurable Neo4j database names.Neo4jConfigingraphiti_mcp_server.pyto parseNEO4J_DATABASE.Graphiticonstructor ingraphiti.pyto acceptdatabaseparameter.databaseparameter toNeo4jDriver.test_graphiti_neo4j_database_parameterintest_graphiti_int.py..env.examplefiles andREADME.mdto documentNEO4J_DATABASEusage and Neo4j Enterprise requirement.This description was created by
for 08df73a. You can customize this summary. It will automatically update as commits are pushed.