fix(release-health): Convert project IDs to slugs #93053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is consistent with e.g. tables when a project column is added. Other datasets handle this project name properly, it seems like only the sessions data uses the project ID when requesting projects. We should probably patch the backend but this is an immediate fix for the feedback.
github-actions
bot
added
the
Scope: Frontend
narsaynorath
commented
Jun 6, 2025
| @@ -64,7 +64,6 @@ export const FIELD_TO_METRICS_EXPRESSION = { | |||
| 'crash_free_rate(user)': SessionMetric.USER_CRASH_FREE_RATE, | |||
| 'crash_rate(session)': SessionMetric.SESSION_CRASH_RATE, | |||
| 'crash_rate(user)': SessionMetric.USER_CRASH_RATE, | |||
| project: 'project_id', | |||
There was a problem hiding this comment.
This was implicitly converting the project field to project_id in the response but it's not really necessary. Instead I just convert the ID to the correct project slug in the afterFetchData helper. Unfortunately, it is on the developer to know the endpoint only returns IDs.
It's possible we can map these back to slugs but I assume it's a limitation of the session data not being immediately join-able with the projects table to do the lookup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is consistent with e.g. tables when a project column is added. Other datasets handle this project name properly, it seems like only the sessions data uses the project ID when requesting projects.
We should probably patch the backend but this is an immediate fix for the feedback.
Before (notice the ID in the legend and tooltip):
After:
