Skip to content

feat(insights): open http response rate chart in comparison view #93050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DominikB2014
Copy link
Contributor

@DominikB2014 DominikB2014 commented Jun 6, 2025

When you click the open to explore button in the http response code chart, we will now open it in the compare query mode. This is because http_response_rate is not a function that will be exposed in explore, so this is a comparable way to get similar data in explore.

To support this, i also had to update generateExploreCompareRoute to accept an array of queries to compare

I.e when you click this
image

It shows up as this
image

@DominikB2014 DominikB2014 requested review from a team as code owners June 6, 2025 18:58
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 6, 2025
Copy link

codecov bot commented Jun 6, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
10510 1 10509 9
View the top 1 failed test(s) by shortest run time
ExploreToolbar opens compare queries
Stack Traces | 0.242s run time
Error: expect(jest.fn()).toHaveBeenCalledWith(...expected)

- Expected
+ Received

  Object {
    "pathname": ".../org-slug/traces/compare/",
-   "query": ObjectContaining {
+   "query": Object {
      "queries": Array [
-       "{\"chartType\":0,\"groupBys\":[],\"query\":\"\",\"sortBys\":[\"-timestamp\"],\"yAxes\":[\"count(span.duration)\"]}",
+       "{\"chartType\":0,\"fields\":[\"id\",\"span.op\",\"span.description\",\"span.duration\",\"transaction\",\"timestamp\"],\"groupBys\":[],\"query\":\"\",\"sortBys\":[\"-timestamp\"],\"yAxes\":[\"count(span.duration)\"]}",
        "{\"fields\":[\"id\",\"span.duration\",\"timestamp\"],\"groupBys\":[],\"query\":\"\",\"sortBys\":[\"-timestamp\"],\"yAxes\":[\"count(span.duration)\"]}",
      ],
    },
  },

Number of calls: 1
    at Object.<anonymous> (.../explore/toolbar/index.spec.tsx:535:25)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants