fix(debug-symbols): Do not require private keys when editing source #93046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After 069d35f private keys and secrets in the debug symbol custom repos were no longer returned as part of the API responses. When editing the repos though, the form still required you to fill them out. This only requires them when not editing existing repos. Fixes: [RTC-808: Replacing Private Key is mandatory when editing custom repositories.](https://linear.app/getsentry/issue/RTC-808/replacing-private-key-is-mandatory-when-editing-custom-repositories)
github-actions
bot
added
the
Scope: Frontend
leeandher
approved these changes
Jun 9, 2025
evanpurkhiser
deleted the
evanpurkhiser/fix-debug-symbols-do-not-require-private-keys-when-editing-source
branch
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93046 +/- ##
==========================================
- Coverage 82.87% 78.06% -4.82%
==========================================
Files 10295 10293 -2
Lines 590951 590929 -22
Branches 22980 22980
==========================================
- Hits 489759 461282 -28477
- Misses 99758 128213 +28455
Partials 1434 1434 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After 069d35f private keys and secrets
in the debug symbol custom repos were no longer returned as part of the
API responses. When editing the repos though, the form still required
you to fill them out.
This only requires them when not editing existing repos.
Fixes: RTC-808: Replacing Private Key is mandatory when editing custom repositories.
Fixes: #90663