-
-
Notifications
You must be signed in to change notification settings - Fork 345
feat(expo): Add RNSentrySDK APIs support to @sentry/react-native/expo plugin #4633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: capture-app-start-errors
Are you sure you want to change the base?
feat(expo): Add RNSentrySDK APIs support to @sentry/react-native/expo plugin #4633
Conversation
|
iOS (legacy) Performance metrics 🚀
|
iOS (new) Performance metrics 🚀
|
Android (legacy) Performance metrics 🚀
|
Android (new) Performance metrics 🚀
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the PR looks good and thank you for the tests!
I still think we could fine tune a bit more the android part and after it we could get ready for merge
Co-authored-by: LucasZF <[email protected]>
Note: The Build & Test / Type Check Typescript 3.8 (pull_request) failure should be fixed when we merge #4673 from |
Co-authored-by: Krystof Woldrich <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have re-checked the PR and overall, I only found a nit on a string. After fixing it and if @krystofwoldrich doesn't find anything else, LGTM!
Co-authored-by: LucasZF <[email protected]>
Co-authored-by: Krystof Woldrich <[email protected]>
I'm currently updating the base branch with the latest main since there was quite a lot of development that was not synced to the feature branch. |
Thank you for the heads up @krystofwoldrich 🙇 |
Co-authored-by: Krystof Woldrich <[email protected]>
…getsentry/sentry-react-native into antonis/4625-expo-useNativeInit
2363742
to
588ba6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fixes. 🚀 It looks great!
@@ -10,6 +10,7 @@ | |||
|
|||
### Features | |||
|
|||
- Add RNSentrySDK APIs support to @sentry/react-native/expo plugin ([#4633](https://github.com/getsentry/sentry-react-native/pull/4633)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit. It would be nice to include an example code snippet and a small summary of what will the flag do.
Co-authored-by: Antonis Lilis <[email protected]>
📢 Type of change
Based on feat: Capture app start errors before JS
📜 Description
Adds RNSentrySDK APIs support to @sentry/react-native/expo plugin by importing sentry and adding injecting
RNSentrySDK.init/start
in the Android MainApplication (Kotlin or Java) or AppDelegate (Objective-C or Swift).This feature is opt-out to enable it set
useNativeInit
totrue
in your@sentry/react-native/expo
plugin configuration.💡 Motivation and Context
Fixes #4625
💚 How did you test it?
CI, Manual
📝 Checklist
sendDefaultPII
is enabled🔮 Next steps