Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/update-deps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
path: modules/sentry-native
- name: CLI
path: scripts/update-cli.ps1
uses: getsentry/github-workflows/.github/workflows/updater.yml@1949ea01ec2da6139d1bcc306c372e6aea76fb72 # v2.13.1
uses: getsentry/github-workflows/.github/workflows/updater.yml@13be9bec4ec5cd67061b747972b996e9c80f4f3b # v3.1.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Key Type Mismatch Breaks Authentication

The secret CI_DEPLOY_KEY appears to be a deploy key (SSH key) based on its name, but it's being passed to the api-token parameter. Version 3.1.0 added a separate ssh-key input specifically for deploy keys and includes validation that detects SSH keys incorrectly passed as api-token. This will likely cause authentication failures.

Fix in Cursor Fix in Web

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Updater Workflow: Old Syntax, New Problems

The workflow uses v3.1.0 with the old v2 reusable workflow syntax. Version 3.0.0 converted the updater to a composite action, requiring migration from job-level uses to step-level uses within a steps: block. The current job-level syntax with .github/workflows/updater.yml path is incompatible with v3 and will fail at runtime.

Fix in Cursor Fix in Web

with:
name: ${{ matrix.name }}
path: ${{ matrix.path }}
Expand Down
Loading