Skip to content

profiling(cocoa): add note about stopping launch profiler #13871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

armcknight
Copy link
Member

DESCRIBE YOUR PR

As noted here: getsentry/sentry-cocoa#3637 (comment)

We have a limitation where we cannot control what happens to a launch profiler if the SDK is never started after a profiled app launch.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented May 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2025 10:19pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2025 10:19pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2025 10:19pm

@armcknight
Copy link
Member Author

I'm not able to see why vercel failed
image

Copy link

codecov bot commented May 29, 2025

Bundle Report

Changes will increase total bundle size by 2.7kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.22MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.77MB 2.71kB (0.03%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
static/media/cd914ecf9c9071d5-*.p.woff2 (New) 36.44kB 36.44kB 100.0% 🚀
static/media/0a86735c6520d94f-*.p.woff2 (New) 35.32kB 35.32kB 100.0% 🚀
static/media/4fca85807f6c09f6-*.woff2 (New) 32.6kB 32.6kB 100.0% 🚀
static/media/d695df15e3ff125c-*.woff2 (New) 32.58kB 32.58kB 100.0% 🚀
static/media/acdf4f392b58827a-*.woff2 (New) 21.13kB 21.13kB 100.0% 🚀
static/media/501d9eeee6e2b0cc-*.woff2 (New) 19.41kB 19.41kB 100.0% 🚀
static/media/e136059a869f199b-*.woff2 (New) 16.46kB 16.46kB 100.0% 🚀
static/media/c1b11e140b58cf5a-*.woff2 (New) 15.11kB 15.11kB 100.0% 🚀
static/media/434c0c74b95acb46-*.woff2 (New) 13.66kB 13.66kB 100.0% 🚀
static/media/60181e10ad16e354-*.woff2 (New) 12.29kB 12.29kB 100.0% 🚀
static/media/a72efd2c2476ebb2-*.woff2 (New) 9.7kB 9.7kB 100.0% 🚀
static/media/9d7436bc73437f75-*.woff2 (New) 9.36kB 9.36kB 100.0% 🚀
static/AUvoSovIDqBR7zyujqn1c/_buildManifest.js (New) 616 bytes 616 bytes 100.0% 🚀
static/AUvoSovIDqBR7zyujqn1c/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/media/b9378c7268e717c1-*.p.woff2 (Deleted) -36.52kB 0 bytes -100.0% 🗑️
static/media/c22ccc5eb58b83e1-*.p.woff2 (Deleted) -35.32kB 0 bytes -100.0% 🗑️
static/media/f1fcc5ff05fc0d5e-*.woff2 (Deleted) -32.42kB 0 bytes -100.0% 🗑️
static/media/356abdd51b933898-*.woff2 (Deleted) -32.26kB 0 bytes -100.0% 🗑️
static/media/8be5568353d67f1e-*.woff2 (Deleted) -20.82kB 0 bytes -100.0% 🗑️
static/media/0596140cb8d9223a-*.woff2 (Deleted) -19.09kB 0 bytes -100.0% 🗑️
static/media/6551d72ebeeac6a7-*.woff2 (Deleted) -16.3kB 0 bytes -100.0% 🗑️
static/media/341baa6ce7a16e81-*.woff2 (Deleted) -15.08kB 0 bytes -100.0% 🗑️
static/media/2a54da80dbfac484-*.woff2 (Deleted) -13.62kB 0 bytes -100.0% 🗑️
static/media/1a4dd1d7cd3232ea-*.woff2 (Deleted) -12.29kB 0 bytes -100.0% 🗑️
static/media/ee8ee7e184152fe5-*.woff2 (Deleted) -8.94kB 0 bytes -100.0% 🗑️
static/media/d70c23d6fe66d464-*.woff2 (Deleted) -8.69kB 0 bytes -100.0% 🗑️
static/mYHKibJ3638MnhvYaEL_G/_buildManifest.js (Deleted) -616 bytes 0 bytes -100.0% 🗑️
static/mYHKibJ3638MnhvYaEL_G/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Copy link
Contributor

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left one comment for potential improvement.

@codeowner-assignment codeowner-assignment bot requested a review from a team June 4, 2025 22:03
@armcknight
Copy link
Member Author

@coolguyzone and @philprime thanks for the reviews, I pushed an improvement that addresses both of your comments, please check it out!

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for updating 🏄‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants