Skip to content

refactor: Add nullability property for screenName #5782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2025

Conversation

philprime
Copy link
Member

@philprime philprime commented Aug 1, 2025

This PR is derived from #5572 in an effort to make the large amount of changes easier to review for #5577.

Changes the parameter screenName to be nullable, as the method implementation allows it.

@philprime philprime self-assigned this Aug 1, 2025
@philprime philprime changed the title refactor: Add nullability property for setCurrentScreen refactor: Add nullability property for screenName Aug 1, 2025
Copy link

codecov bot commented Aug 1, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
31824 1 31823 97
View the top 1 failed test(s) by shortest run time
iOS_SwiftUI_UITests.LaunchUITests::testTTID_TTFD
Stack Traces | 0s run time
.../iOS-SwiftUI/iOS-SwiftUI-UITests/LaunchUITests.swift:81 - Failed to terminate io.sentry.iOS-SwiftUI:8923: Failed to terminate io.sentry.iOS-SwiftUI:0

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link
Contributor

github-actions bot commented Aug 1, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1244.96 ms 1267.14 ms 22.18 ms
Size 23.75 KiB 913.17 KiB 889.42 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
f92cfa9 1217.94 ms 1240.06 ms 22.12 ms
63ac649 1192.10 ms 1216.78 ms 24.68 ms
cda95fc 1231.42 ms 1247.18 ms 15.77 ms
80a5166 1224.49 ms 1251.29 ms 26.80 ms
b714cb9 1224.71 ms 1238.04 ms 13.33 ms
ac4739e 1236.55 ms 1258.89 ms 22.34 ms
2bddb03 1214.11 ms 1246.78 ms 32.67 ms
079bcc8 1217.88 ms 1234.88 ms 17.00 ms
7148f97 1235.09 ms 1258.07 ms 22.98 ms
9e0030e 1222.78 ms 1242.23 ms 19.45 ms

App size

Revision Plain With Sentry Diff
f92cfa9 23.75 KiB 855.38 KiB 831.63 KiB
63ac649 23.75 KiB 855.38 KiB 831.63 KiB
cda95fc 23.75 KiB 912.77 KiB 889.02 KiB
80a5166 23.75 KiB 904.53 KiB 880.78 KiB
b714cb9 23.75 KiB 858.69 KiB 834.93 KiB
ac4739e 23.75 KiB 872.67 KiB 848.92 KiB
2bddb03 23.75 KiB 891.01 KiB 867.26 KiB
079bcc8 23.74 KiB 874.07 KiB 850.33 KiB
7148f97 23.75 KiB 854.78 KiB 831.03 KiB
9e0030e 23.75 KiB 893.72 KiB 869.97 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping the PRs small.

@philprime philprime merged commit 7f2f69c into main Aug 5, 2025
131 of 133 checks passed
@philprime philprime deleted the philprime/strict-nullability-8 branch August 5, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants