Fix integer overflow in times_seen field #5187
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an
integer out of rangeerror in thetimes_seencolumn ofsentry_groupedmessage.This error occurs when client SDKs send events with extremely low
sample_ratevalues. The Sentry backend calculatestimes_seenby inverting this rate (1 / sample_rate), which can result in a value exceeding PostgreSQL'sintegerfield limit (2,147,483,647).This PR introduces a validation function in Relay (
validate_sample_rate_for_times_seen) that caps the effectivesample_rateif its inverse would lead to an integer overflow. This validation is applied during event normalization and to Dynamic Sampling Contexts.This prevents database errors by ensuring
times_seenvalues remain within PostgreSQL's integer bounds, with warnings logged when a sample rate is capped.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.