Skip to content

Conversation

myleshorton
Copy link
Contributor

This pull request introduces support for a new "proxyless" feature across multiple components of the application. Key changes include backend logic to manage proxyless settings, UI updates to expose the feature in the settings, and necessary updates to the session model. Additionally, minor improvements and fixes were made to existing code.

Proxyless Feature Implementation:

  • Backend support for proxyless settings:

    • Added a new constant pathProxyless in internalsdk/session_model.go to define the proxyless path.
    • Implemented setProxyless and ProxylessEnabled methods in SessionModel to handle proxyless state management. [1] [2] [3]
  • UI integration for proxyless toggle:

    • Added a new proxyless settings item in lib/features/account/settings.dart, including a CupertinoSwitch for toggling the proxyless state.
    • Introduced a new proxyless icon in lib/common/ui/image_paths.dart.
  • Session model updates:

    • Added proxylessNotifier and corresponding methods to lib/features/home/session_model.dart for managing proxyless state in the app. [1] [2] [3]

Minor Improvements and Fixes:

  • Improved directory creation in hit_proxy.bash:

    • Replaced mkdir -p with mkdir -pv for verbose output and added error handling when fetching proxy configuration.
  • UI consistency updates:

    • Fixed trailing commas in lib/features/account/settings.dart for better formatting. [1] [2]
    • Corrected CupertinoSwitch property name in lib/features/account/split_tunneling.dart.

@myleshorton
Copy link
Contributor Author

myleshorton commented Jul 26, 2025

TODO:

  • Add a translation string for proxyless
  • Actually wire the setting up so that the dialing code can read it
  • Add an overlay a la proxy all that describes the feature

@myleshorton myleshorton marked this pull request as draft July 26, 2025 00:07
@myleshorton
Copy link
Contributor Author

I added a couple of translation strings to assets/locales/en-us.po. What's the process for getting those translated @Derekf5?

@Derekf5
Copy link

Derekf5 commented Jul 28, 2025

I went into transifex to see if those strings had been pushed to the Flutter repo, and I don't see anything related to proxyless. @jigar-f or @atavism might have a better idea of how that works. Once they are pushed over, I can get them translated.

@myleshorton myleshorton changed the title WIP for adding a proxyless toggle setting Proxyless toggle setting on Android Jul 28, 2025
@myleshorton myleshorton marked this pull request as ready for review July 28, 2025 22:02
@myleshorton
Copy link
Contributor Author

This just needs some translations

@myleshorton
Copy link
Contributor Author

Oh and we need to merge the related flashlight branch...

@myleshorton myleshorton marked this pull request as draft July 28, 2025 22:06
@jigar-f
Copy link
Contributor

jigar-f commented Jul 29, 2025

We have CI that pulls and pushes changes to Transifex. Once you push changes to main, it will push string to Transifex, and then at midnight it will pull changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants