-
Notifications
You must be signed in to change notification settings - Fork 5
Proxyless toggle setting on Android #1367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
myleshorton
wants to merge
12
commits into
main
Choose a base branch
from
myles/proxyless-setting
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO:
|
I added a couple of translation strings to assets/locales/en-us.po. What's the process for getting those translated @Derekf5? |
This just needs some translations |
Oh and we need to merge the related flashlight branch... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for a new "proxyless" feature across multiple components of the application. Key changes include backend logic to manage proxyless settings, UI updates to expose the feature in the settings, and necessary updates to the session model. Additionally, minor improvements and fixes were made to existing code.
Proxyless Feature Implementation:
Backend support for proxyless settings:
pathProxyless
ininternalsdk/session_model.go
to define the proxyless path.setProxyless
andProxylessEnabled
methods inSessionModel
to handle proxyless state management. [1] [2] [3]UI integration for proxyless toggle:
lib/features/account/settings.dart
, including aCupertinoSwitch
for toggling the proxyless state.lib/common/ui/image_paths.dart
.Session model updates:
proxylessNotifier
and corresponding methods tolib/features/home/session_model.dart
for managing proxyless state in the app. [1] [2] [3]Minor Improvements and Fixes:
Improved directory creation in
hit_proxy.bash
:mkdir -p
withmkdir -pv
for verbose output and added error handling when fetching proxy configuration.UI consistency updates:
lib/features/account/settings.dart
for better formatting. [1] [2]CupertinoSwitch
property name inlib/features/account/split_tunneling.dart
.