add UPDATE_FAIL to issue selection; remove spinning, chat_not_working; cannot_link_device (after user/pass)
#1299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jay-418
changed the title
spinning, chat_not_working; cannot_link_device (after user/pass)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to:
https://github.com/getlantern/customer-support/issues/621
https://github.com/getlantern/engineering/issues/1823
New code should not be using FutureBuilder (use ValueListenableBuilder instead)
All strings are defined using localized message keys like
'my_message_key'.i18nand are defined inen.po.All colors are defined using Hex (not using built-in colors), are defined in
colors.dartand are not duplicatedAll text styles are defined in
text_styles.dartand are not duplicatedAll icons are using the vector resource from Figma (do not use built-in Icons)
Repeated code has been factored into custom widgets
Layout looks good in both LTR (English) and RTL (Persian) languages
If you refactored existing code, have you tested the refactored functionality against the old version to make sure you didn't break anything?
Do the tests pass? Consistently?
Did this change improve test coverage?
Is the code in question being linted? If not, consider adding a linter step to CI. If yes, make sure the linter is happy.
Have you logged tickets for related technical debt with the label “techdebt”?